Message 200084 - Python tracker

➜

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

In-reply-to
Author	lemburg
Recipients	eric.araujo, fredericaltorres, lemburg, numerodix
Date	2013年10月16日.20:49:39
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1381956579.2.0.408764626038.issue8964@psf.upfronthosting.co.za>

Content
The patch looks good, except one nit: if 'IronPython' in sys_version is probably not supported in IronPython 2.0, since support for "n-char in m-char" tests were added after Python 2.1. Now, you can either leave this in and remove the IronPython 2.0 support from platform.py (which is fine, IMO), or change the test to use the .find() method.

Content

The patch looks good, except one nit:
if 'IronPython' in sys_version
is probably not supported in IronPython 2.0, since support for "n-char in m-char" tests were added after Python 2.1.
Now, you can either leave this in and remove the IronPython 2.0 support from platform.py (which is fine, IMO), or change the test to use the .find() method.

History
Date	User	Action	Args
2013年10月16日 20:49:39	lemburg	set	recipients: + lemburg, eric.araujo, fredericaltorres, numerodix
2013年10月16日 20:49:39	lemburg	set	messageid: <1381956579.2.0.408764626038.issue8964@psf.upfronthosting.co.za>
2013年10月16日 20:49:39	lemburg	link	issue8964 messages
2013年10月16日 20:49:39	lemburg	create

homepage