Message197792
| Author |
barry |
| Recipients |
Arfrever, akuchling, barry, benjamin.peterson, christian.heimes, georg.brandl, giampaolo.rodola, larry, r.david.murray, serhiy.storchaka |
| Date |
2013年09月15日.16:54:20 |
| SpamBayes Score |
-1.0 |
| Marked as misclassified |
Yes |
| Message-id |
<20130915125405.29ba135e@anarchist> |
| In-reply-to |
<1379263653.25.0.722698801999.issue16042@psf.upfronthosting.co.za> |
| Content |
On Sep 15, 2013, at 04:47 PM, Serhiy Storchaka wrote:
>It is not important in the context of this issue, but readline(0) is blocked
>and returns 1-character string. Move the length check above
>self.sslobj.read(1). For readability you can also move the chr != "\n" inside
>the loop:
>
> while size is None or len(str) < size:
> chr = self.sslobj.read(1)
> if not chr or chr == "\n": break
> str += chr
Hi Serhiy. Is there a functional difference to re-arranging this loop?
All things being equal, the minimal change is probably best.
Also, what do you mean by "readline(0) is blocked"? Do you mean this is a
blocking call or something else? |
|