Message194798
| Author |
eli.bendersky |
| Recipients |
Arfrever, Robin.Schreiber, asvetlov, effbot, eli.bendersky, pitrou, python-dev |
| Date |
2013年08月10日.15:07:25 |
| SpamBayes Score |
-1.0 |
| Marked as misclassified |
Yes |
| Message-id |
<1376147246.03.0.431690684519.issue15651@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
Antoine, I committed your patch (with a bit of comments added), *leaving the module caching in*. This is because removing it breaks the tests, unfortunately. The _elementtree tests are so crooked that they manage to create a situation in which the module under test throws ParseError which is a different class from ET.ParseError. This is "achieved" by multiple invocations of import_fresh_module with various fresh & blocked parameters, and I still haven't fully traced all the problems yet. Since this caching only potentially harms other tests, it's ok to leave in.
A longer term solution to all this will be http://mail.python.org/pipermail/python-dev/2013-August/127766.html - I want to eventually run all "monkey-patch the import environment to simulate some situation" sub-tests of ET in different subprocesses to they are kept independent. |
|