Message 192363 - Python tracker

➜

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

In-reply-to
Author	madison.may
Recipients	brett.cannon, madison.may
Date	2013年07月05日.21:52:45
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1373061166.56.0.861377783196.issue18351@psf.upfronthosting.co.za>

Content
Here's a preliminary attempt at a patch and a small set of test cases for _get_sourcefile. I fixed one more spelling error in _get_sourcefile (bytcode -> bytecode) and tweaked a bit of logic. Instead of: extension.lower()[-3:-1] != '.py' I think we needed extension.lower()[-3:-1] != 'py' You must have been having a rough day, Brett =). Anyhow, when you get a chance, take a look at this first attempt and let me know what you'd do differently. Thanks, Madison

Content

Here's a preliminary attempt at a patch and a small set of test cases for _get_sourcefile. I fixed one more spelling error in _get_sourcefile (bytcode -> bytecode) and tweaked a bit of logic.
Instead of:
extension.lower()[-3:-1] != '.py' 
I think we needed
extension.lower()[-3:-1] != 'py'
You must have been having a rough day, Brett =). Anyhow, when you get a chance, take a look at this first attempt and let me know what you'd do differently.
Thanks,
Madison

History
Date	User	Action	Args
2013年07月05日 21:52:46	madison.may	set	recipients: + madison.may, brett.cannon
2013年07月05日 21:52:46	madison.may	set	messageid: <1373061166.56.0.861377783196.issue18351@psf.upfronthosting.co.za>
2013年07月05日 21:52:46	madison.may	link	issue18351 messages
2013年07月05日 21:52:46	madison.may	create

homepage