Message192340
| Author |
brett.cannon |
| Recipients |
brett.cannon, madison.may |
| Date |
2013年07月05日.17:48:45 |
| SpamBayes Score |
-1.0 |
| Marked as misclassified |
Yes |
| Message-id |
<1373046526.31.0.573901179665.issue18351@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
Wow, I really botched that function. And no one seems to really use it to notice the errors (or at least the branches in the function where the errors exist are never reached). =)
So the tests should go in test_importlib or test_import (I'm leaning towards the latter since this function is for the C API). As for the files, I wouldn't create any and instead mock out importlib._bootstrap._path_isfile() to return the value you want.
And one last thing, Madison, is to do the patch against Python 3.3 if you can. This obviously needs to be backported so it's best to start there and then work forward. |
|
History
|
|---|
| Date |
User |
Action |
Args |
| 2013年07月05日 17:48:46 | brett.cannon | set | recipients:
+ brett.cannon, madison.may |
| 2013年07月05日 17:48:46 | brett.cannon | set | messageid: <1373046526.31.0.573901179665.issue18351@psf.upfronthosting.co.za> |
| 2013年07月05日 17:48:46 | brett.cannon | link | issue18351 messages |
| 2013年07月05日 17:48:45 | brett.cannon | create |
|