Message190697
| Author |
belopolsky |
| Recipients |
belopolsky, eric.smith, francismb, jbatista, joar, maker, petri.lehtinen, ronaldoussoren, thezulk |
| Date |
2013年06月05日.22:05:47 |
| SpamBayes Score |
-1.0 |
| Marked as misclassified |
Yes |
| Message-id |
<1370469948.13.0.0145008149013.issue17267@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
I left a few minor comments on rietveld for the last patch. I did not see code for time.now() and I don't think adding now() should be combined with time +/- timedelta patch. Let's do one thing at a time.
I think time + timedelta addition is fairly uncontroversial. In the past, I argued against using detached time objects, but it is not really a valid reason for rejecting a good feature.
On subtraction, if we add time - timedelta -> time, I think users would expect time - time -> timedelta as well. This, however, is ambiguous if we stay with mod 24h arithmetic. The ambiguity can be lifted by requiring days=0 in the result. |
|