Message190241
| Author |
sbt |
| Recipients |
BreamoreBoy, brian.curtin, sbt, terry.reedy, tim.golden, zach.ware |
| Date |
2013年05月28日.20:06:19 |
| SpamBayes Score |
-1.0 |
| Marked as misclassified |
Yes |
| Message-id |
<1369771579.58.0.801179770243.issue16895@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
I can't say I know enough about batch files to understand much of the code, but a few notes:
Windows XP does not have the command "where" which you use -- Python 3.4 will still support XP.
Except perhaps for looping I would prefer to get rid of the use of goto. The fact that some goto targets end in "exit /b ..." make it very confusing as to where "exit /b" will return control.
The initial pushd is matched by various popd's which are scattered over hundreds of lines (including one in :usage). I think it would be better to keep matching pushd/popd reasonably close together. For instance, I think you could do something like
...
pushd "%~dp0"
call :main ...
popd
exit /b
:main
...
exit /b
It would also be helpful if the end of the subroutines were marked with a comment like
rem end :foo |
|