Message189897
| Author |
eric.snow |
| Recipients |
alex, asvetlov, benjamin.peterson, eric.araujo, eric.snow, ezio.melotti, flox, rhettinger, serhiy.storchaka |
| Date |
2013年05月24日.05:56:51 |
| SpamBayes Score |
-1.0 |
| Marked as misclassified |
Yes |
| Message-id |
<1369375020.46.0.125444740886.issue16991@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
I finally had some time so here's an updated patch (including O(1) deletions). I've also added a bunch of notes at the top of odictobject.c. Some notable things left to do:
* address two recently failing tests due to r83881 (issue 17900)
* check for any reference cycles (should be fine)
* validate reentrancy (make sure everything is thread-safe around calls into Python)
* make sure subclassing is okay
* compare performance to dict, pure Python OrderedDict
My goal here is to get an effective OrderedDict that we are happy with, while recognizing that there is room for optimization. However, I won't be okay with faultiness, so the implementation must be complete. This has been my mindset throughout. |
|