Message 189785 - Python tracker

➜

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

In-reply-to
Author	amaury.forgeotdarc
Recipients	amaury.forgeotdarc, dongying, eli.bendersky, ezio.melotti, flox, serhiy.storchaka, terry.reedy, vstinner
Date	2013年05月21日.20:59:40
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1369169981.17.0.399010172165.issue13612@psf.upfronthosting.co.za>

Content
The patch goes in the right direction: consistently reject non-8bit encodings which the current implementation does not support. - please add a unit test - remove usage of PyUnicodeObject and the "Stupid to access directly" comment, they are outdated. Real support for GBK is more work, http://wang.yuxuan.org/blog/?itemid=63 shows how to set a conversion callback. It will difficult to implement in the general case, see my older comment.

Content

The patch goes in the right direction: consistently reject non-8bit encodings which the current implementation does not support.
- please add a unit test
- remove usage of PyUnicodeObject and the "Stupid to access directly" comment, they are outdated.
Real support for GBK is more work, http://wang.yuxuan.org/blog/?itemid=63 shows how to set a conversion callback. It will difficult to implement in the general case, see my older comment.

History
Date	User	Action	Args
2013年05月21日 20:59:41	amaury.forgeotdarc	set	recipients: + amaury.forgeotdarc, terry.reedy, vstinner, ezio.melotti, eli.bendersky, flox, dongying, serhiy.storchaka
2013年05月21日 20:59:41	amaury.forgeotdarc	set	messageid: <1369169981.17.0.399010172165.issue13612@psf.upfronthosting.co.za>
2013年05月21日 20:59:41	amaury.forgeotdarc	link	issue13612 messages
2013年05月21日 20:59:40	amaury.forgeotdarc	create

homepage