Message188281
| Author |
pitrou |
| Recipients |
Arfrever, alexandre.vassalotti, asvetlov, neologix, pitrou, rhettinger, serhiy.storchaka |
| Date |
2013年05月02日.21:16:17 |
| SpamBayes Score |
-1.0 |
| Marked as misclassified |
Yes |
| Message-id |
<1367529375.2551.14.camel@fsol> |
| In-reply-to |
<1367528401.47.0.364612925247.issue17810@psf.upfronthosting.co.za> |
| Content |
> One concern is we need to make sure the C implementation call
> _Pickler_OpcodeBoundary often enough to keep the frames around the
> sizes. For example, batch_save_list and batch_save_dict can currently
> create a frame much larger than expected.
I don't understand how that can happen. batch_list() and batch_dict()
both call save() for each item, and save() calls
_Pickler_OpcodeBoundary() at the end. Have I missed something?
> Interestingly enough, I found pickle, with patch applied, crashes when
> handling such frames:
Interesting, I'll take a look when I have some time.
> Also, I think we should try to make pickletools.dis display the frame
> boundaries to help with debugging. This could be implemented by adding
> an option to pickletools.genops which could be helpful for testing the
> framing implementation as well.
Agreed. |
|