Message187786
| Author |
orsenthil |
| Recipients |
demian.brecht, ezio.melotti, orsenthil, python-dev, r.david.murray, terry.reedy |
| Date |
2013年04月25日.14:41:47 |
| SpamBayes Score |
-1.0 |
| Marked as misclassified |
Yes |
| Message-id |
<1366900908.02.0.568194660054.issue17272@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
I have committed the first patch which makes Request.full_url a descriptor.
As I was looking at the changes to be introduced by second patch, I noticed that we do not have comprehensive test coverage for .full_url public attribute. All the tests are testing the methods like get_full_url.
The change for .full_url not to include fragments was introduced in 63817:bf3359b7ed2e which says that for reasons that HTTP request should not include fragments, it was done. That's correct. Now, I would fear to introduce that bug again with the second patch wherein we inadvertently send a URL with fragment in a HTTP request. To ensure this will not be the case, I think, increase in test coverage, understanding and documenting the exact expectation will be necessary if we have to change Request.full_url behavior. I will be spending a little more time on it. I thought I will write down the points which should be taken care. |
|