Message187085
| Author |
alex |
| Recipients |
Arfrever, alex, brett.cannon, mark.dickinson, rhettinger, scoder, serhiy.storchaka |
| Date |
2013年04月16日.14:31:40 |
| SpamBayes Score |
-1.0 |
| Marked as misclassified |
Yes |
| Message-id |
<1366122701.08.0.423072601396.issue16659@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
Looking at the patch (haven't actually benchmarked it), I have two concerns with respect to performance:
a) The need for locking, this doesn't exist in the C or RPython versions because of the GIL. That locking is going to be distinctly un-free.
b) The need for manually masking overflowing arithmetic (yes I know, everything is a long, but just looking at it algorithmically, we really want the 2s complement).
I don't have an opinion about how to solve either of these, but without a solution I doubt performance will ever be competitive. I think it would be a mistake to assume these issues are specific to this patch, they strike me as generally applicable issues. |
|