Message186057
| Author |
cbc |
| Recipients |
Ankur.Ankan, cbc, chris.jerdonek, eli.bendersky |
| Date |
2013年04月04日.23:00:22 |
| SpamBayes Score |
-1.0 |
| Marked as misclassified |
Yes |
| Message-id |
<1365116423.19.0.279110411046.issue15518@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
OK, I got to participate in my Python user group hack night this week where I actually got to work on my projects instead of spending all night helping newbies on their projects. I used the time to refactor all the previous patches for this issue on which I had previously been working into the attached issue-15518-1.patch (replacing previous patch of the same name). I believe this patch a) provides the necessary minimum test coverage for the report methods, b) addresses chris.jerdonek's and eli.bendersky concerns, and c) does a strict PEP8 clean-up of the pre-existing tests (without changing pre-existing code). If you like this patch, I'd be glad to refactor the pre-existing tests to a) put each pre-existing test in its own TestCase methods and b) clean-up the unmaintainable proliferation of repeated hard-coded strings in the pre-existing tests. Feedback appreciated. |
|