Message 185462 - Python tracker

➜

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

In-reply-to
Author	gregory.p.smith
Recipients	donmez, ezio.melotti, gregory.p.smith, matejcik, neologix, pitrou, vstinner
Date	2013年03月28日.19:22:46
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1364498566.5.0.147462798909.issue12466@psf.upfronthosting.co.za>

Content
phew, yay. because i didn't see anything obviously wrong with the #16962 commit. also, regarding checking for EINTR on some of the close() calls. It isn't a big deal. This _posixsubprocess.c code that contains those checks is always executing single-threaded post-fork so there is no chance of a race condition even though the EINTR check and retry are pointless as Linus mentions. They will never cause errant behavior but I'll "fix" them in a future commit for consistency.

Content

phew, yay. because i didn't see anything obviously wrong with the #16962 commit.
also, regarding checking for EINTR on some of the close() calls. It isn't a big deal. This _posixsubprocess.c code that contains those checks is always executing single-threaded post-fork so there is no chance of a race condition even though the EINTR check and retry are pointless as Linus mentions. They will never cause errant behavior but I'll "fix" them in a future commit for consistency.

History
Date	User	Action	Args
2013年03月28日 19:22:46	gregory.p.smith	set	recipients: + gregory.p.smith, pitrou, vstinner, donmez, matejcik, ezio.melotti, neologix
2013年03月28日 19:22:46	gregory.p.smith	set	messageid: <1364498566.5.0.147462798909.issue12466@psf.upfronthosting.co.za>
2013年03月28日 19:22:46	gregory.p.smith	link	issue12466 messages
2013年03月28日 19:22:46	gregory.p.smith	create

homepage