Message183773
| Author |
eric.araujo |
| Recipients |
BreamoreBoy, ajaksu2, anthonybaxter, barry, dalke, eric.araujo, gaul, karlcow, l0nwlf, orsenthil, r.david.murray |
| Date |
2013年03月08日.23:30:31 |
| SpamBayes Score |
-1.0 |
| Marked as misclassified |
Yes |
| Message-id |
<1362785431.49.0.198705096487.issue747320@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
Tests would be great, especially given that we can add them in 3.2 and when merging 3.2 into 3.3 and then default, it ensures that the new code has no regression.
(A minor thing: I would use "attribute" instead of "variable" in the docstrings.)
There are also test helpers to assert that a warning is sent, but we don’t have a full coverage policy so it’s okay if you don’t feel like adding them. |
|
History
|
|---|
| Date |
User |
Action |
Args |
| 2013年03月08日 23:30:31 | eric.araujo | set | recipients:
+ eric.araujo, barry, anthonybaxter, gaul, dalke, orsenthil, ajaksu2, r.david.murray, karlcow, l0nwlf, BreamoreBoy |
| 2013年03月08日 23:30:31 | eric.araujo | set | messageid: <1362785431.49.0.198705096487.issue747320@psf.upfronthosting.co.za> |
| 2013年03月08日 23:30:31 | eric.araujo | link | issue747320 messages |
| 2013年03月08日 23:30:31 | eric.araujo | create |
|