Message183347
| Author |
francismb |
| Recipients |
belopolsky, eric.smith, francismb, jbatista, joar, maker, petri.lehtinen, ronaldoussoren, thezulk |
| Date |
2013年03月02日.20:16:03 |
| SpamBayes Score |
-1.0 |
| Marked as misclassified |
Yes |
| Message-id |
<1362255363.35.0.683612146334.issue17267@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
Hi Joar,
just a detail: is there a reason for the asymmetric check for timedelta isinstance (and raising NotImplemented)? And BTW. isn't a double check for the __sub__ case (or have I missed something)?
+ def __add__(self, other):
+ "Add a time and a timedelta"
+ if not isinstance(other, timedelta):
+ return NotImplemented
vs.
...
+ def __sub__(self, other):
+ "Subtract a time and a timedelta."
+ if isinstance(other, timedelta):
+ return self + -other
+ return NotImplemented
regards,
francis |
|