Message 183177 - Python tracker

➜

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

In-reply-to
Author	brett.cannon
Recipients	brett.cannon, sbt
Date	2013年02月27日.19:56:34
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1361994994.99.0.625564916049.issue17314@psf.upfronthosting.co.za>

Content
I'm trying to remove all uses of imp.find_module()/load_module() and multiprocessing seems to have a single use of both purely for (re)loading a module. The attached patch moves over to importlib.find_loader() and subsequent load_module() call to match the semantics of imp.find_module()/load_module(). If a guaranteed reload is not necessary then importlib.import_module() is a single-line change. I ran the test suite, but there don't seem to be any explicit tests for this chunk of code (or am I missing something?).

Content

I'm trying to remove all uses of imp.find_module()/load_module() and multiprocessing seems to have a single use of both purely for (re)loading a module. The attached patch moves over to importlib.find_loader() and subsequent load_module() call to match the semantics of imp.find_module()/load_module(). If a guaranteed reload is not necessary then importlib.import_module() is a single-line change.
I ran the test suite, but there don't seem to be any explicit tests for this chunk of code (or am I missing something?).

History
Date	User	Action	Args
2013年02月27日 19:56:35	brett.cannon	set	recipients: + brett.cannon, sbt
2013年02月27日 19:56:34	brett.cannon	set	messageid: <1361994994.99.0.625564916049.issue17314@psf.upfronthosting.co.za>
2013年02月27日 19:56:34	brett.cannon	link	issue17314 messages
2013年02月27日 19:56:34	brett.cannon	create

homepage