Message183096
| Author |
Emil.Lind |
| Recipients |
Arfrever, Emil.Lind, benjamin.peterson, christian.heimes, georg.brandl, giampaolo.rodola, larry |
| Date |
2013年02月26日.22:10:51 |
| SpamBayes Score |
-1.0 |
| Marked as misclassified |
Yes |
| Message-id |
<1361916652.48.0.797273397688.issue16039@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
I'm uploading my first patch.
Heavily based on the related issues for ftplib and poplib.
Need help with review and a few questions...
Q1: Is the error Exception the right way to handle the "breach" (disconnects client?) or is there a better way? Like a 'BAD' response...
Q2: I'm not sure how to best modify the test_imaplib for this patch. I'm guessing a make_server where the client gets MAXLINE+1 bytes of data and validates exception. But it's above my abilities right now...
I welcome any input, thanks.
note: patch seems to apply to 2.7, 3.2, 3.3, 3.4 |
|