Message 182217 - Python tracker

➜

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

In-reply-to
Author	seebk
Recipients	harveyormston, jcea, mark.dickinson, seebk
Date	2013年02月16日.11:15:53
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1361013354.5.0.110230499177.issue16525@psf.upfronthosting.co.za>

Content
Thanks for the hint Harvey! I have updated my patch to include your changes, but only applied the second hunk for the following reasons: Wave_read should not assume any wave format, as it is expected to open a file during initialization. So actually the only missing thing was the assignment of the wave format during the reading of the format chunk. setparams() in Wave_write already sets the wavformat a few lines later together with the other parameters. So no need to set it twice... Can you please check if the updated patch works for you?

Content

Thanks for the hint Harvey!
I have updated my patch to include your changes, but only applied the second hunk for the following reasons:
Wave_read should not assume any wave format, as it is expected to open a file during initialization. So actually the only missing thing was the assignment of the wave format during the reading of the format chunk.
setparams() in Wave_write already sets the wavformat a few lines later together with the other parameters. So no need to set it twice...
Can you please check if the updated patch works for you?

History
Date	User	Action	Args
2013年02月16日 11:15:54	seebk	set	recipients: + seebk, jcea, mark.dickinson, harveyormston
2013年02月16日 11:15:54	seebk	set	messageid: <1361013354.5.0.110230499177.issue16525@psf.upfronthosting.co.za>
2013年02月16日 11:15:54	seebk	link	issue16525 messages
2013年02月16日 11:15:54	seebk	create

homepage