Message 181980 - Python tracker

➜

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

In-reply-to
Author	giampaolo.rodola
Recipients	georg.brandl, giampaolo.rodola, pitrou
Date	2013年02月12日.22:40:09
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1360708809.53.0.302633878748.issue17197@psf.upfronthosting.co.za>

Content
profile and cProfile modules define the same utility functions (run() and runctx()) which use the same code except the profiler class. Considering that we're going to add 2 new utility functions (runcall() and runblock(), see issue9285 and issue17130) I think we should refactor the code in order to avoid this code duplication. Patch in attachment does that. The approach I came up with looks a bit hackish though so I'd like to get some feedback. Is it acceptable?

Content

profile and cProfile modules define the same utility functions (run() and runctx()) which use the same code except the profiler class.
Considering that we're going to add 2 new utility functions (runcall() and runblock(), see issue9285 and issue17130) I think we should refactor the code in order to avoid this code duplication.
Patch in attachment does that.
The approach I came up with looks a bit hackish though so I'd like to get some feedback. Is it acceptable?

History
Date	User	Action	Args
2013年02月12日 22:40:09	giampaolo.rodola	set	recipients: + giampaolo.rodola, georg.brandl, pitrou
2013年02月12日 22:40:09	giampaolo.rodola	set	messageid: <1360708809.53.0.302633878748.issue17197@psf.upfronthosting.co.za>
2013年02月12日 22:40:09	giampaolo.rodola	link	issue17197 messages
2013年02月12日 22:40:09	giampaolo.rodola	create

homepage