Message179584
| Author |
serhiy.storchaka |
| Recipients |
berker.peksag, christian.heimes, ezio.melotti, felipecruz, jcon, mrshu, serhiy.storchaka |
| Date |
2013年01月10日.19:18:46 |
| SpamBayes Score |
-1.0 |
| Marked as misclassified |
Yes |
| Message-id |
<1357845527.12.0.803579462543.issue15948@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
Some general notes. Nitpick: check foo() < 0 is more used than foo() == 0. An exception raised after failed close() can hide original exception raised before. I left more specific comments on Rietveld.
Only a small part of the proposed changes may be approved by me. About the majority of changes only the module maintainer can say how they are safe and how to do correctly (they looks too risky for me). Some of the changes are obviously wrong. |
|