Message 178615 - Python tracker

➜

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

In-reply-to
Author	vstinner
Recipients	BreamoreBoy, benjamin.peterson, ezio.melotti, kushal.das, loewis, pitrou, serhiy.storchaka, thomaslee, vstinner
Date	2012年12月30日.21:36:50
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1356903410.95.0.414339144986.issue16061@psf.upfronthosting.co.za>

Content
str_replace_1char.patch: why not implementing replace_1char_inplace() in stringlib, with one version per character type (UCS1, UCS2, UCS4)? I prefer unicode_2.patch algorithm because it's simpler: only one loop (vs two loops for str_replace_1char.patch, with a threshold of 10 different characters). Why do you changed your algorithm? Is str_replace_1char.patch algorithm more efficient than unicode_2.patch algorithm? Is the speedup really interesting?

Content

str_replace_1char.patch: why not implementing replace_1char_inplace() in stringlib, with one version per character type (UCS1, UCS2, UCS4)?
I prefer unicode_2.patch algorithm because it's simpler: only one loop (vs two loops for str_replace_1char.patch, with a threshold of 10 different characters).
Why do you changed your algorithm? Is str_replace_1char.patch algorithm more efficient than unicode_2.patch algorithm? Is the speedup really interesting?

History
Date	User	Action	Args
2012年12月30日 21:36:51	vstinner	set	recipients: + vstinner, loewis, pitrou, thomaslee, benjamin.peterson, ezio.melotti, BreamoreBoy, serhiy.storchaka, kushal.das
2012年12月30日 21:36:50	vstinner	set	messageid: <1356903410.95.0.414339144986.issue16061@psf.upfronthosting.co.za>
2012年12月30日 21:36:50	vstinner	link	issue16061 messages
2012年12月30日 21:36:50	vstinner	create

homepage