Message 177229 - Python tracker

➜

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

In-reply-to
Author	gregory.p.smith
Recipients	asvetlov, gregory.p.smith, pitrou, serhiy.storchaka
Date	2012年12月09日.18:00:08
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1355076009.0.0.786776519063.issue16650@psf.upfronthosting.co.za>

Content
it's a potential bug. your patch looks good. as for _handle_exitstatus referring to SubprocessError, that is fine. In that situation it is trying to raise the exception and the only time that would ever be a problem is when called by the gc during a __del__ where such an exception for this "impossible" situation cannot be caught anyways. It would effectively become an uncaught NameError instead of an uncaught SubprocessError; not a big deal.

Content

it's a potential bug. your patch looks good.
as for _handle_exitstatus referring to SubprocessError, that is fine. In that situation it is trying to raise the exception and the only time that would ever be a problem is when called by the gc during a __del__ where such an exception for this "impossible" situation cannot be caught anyways. It would effectively become an uncaught NameError instead of an uncaught SubprocessError; not a big deal.

History
Date	User	Action	Args
2012年12月09日 18:00:09	gregory.p.smith	set	recipients: + gregory.p.smith, pitrou, asvetlov, serhiy.storchaka
2012年12月09日 18:00:09	gregory.p.smith	set	messageid: <1355076009.0.0.786776519063.issue16650@psf.upfronthosting.co.za>
2012年12月09日 18:00:08	gregory.p.smith	link	issue16650 messages
2012年12月09日 18:00:08	gregory.p.smith	create

homepage