homepage

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author vstinner
Recipients amaury.forgeotdarc, vstinner
Date 2012年11月09日.01:14:49
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1352423690.29.0.110802131091.issue16447@psf.upfronthosting.co.za>
In-reply-to
Content
It looks like the bug is the pattern "Py_DECREF(obj->attr); obj->attr = new_value;". Replacing it with "{ PyObject *tmp = obj->attr; obj->attr = new_value; Py_DECREF(tmp); }" does fix this specific issue.
We can use the coccinelle tool to replace all such patterns in the whole CPython code base using attached py_decref_replace.spatch "semantic patch". See also issue #16445, I proposed a similar idea (and another semantic patch).
Attached python27_decref_replace.patch patch is the result of the command "spatch -in_place -sp_file py_decref_replace.spatch -dir .".
The patch is quite huge, I didn't read it yet :-)
 Mac/Modules/carbonevt/_CarbonEvtmodule.c | 7 +++++--
 Mac/Modules/list/_Listmodule.c | 7 +++++--
 Modules/_bsddb.c | 42 ++++++++++++++++++++++++++++++------------
 Modules/_csv.c | 7 +++++--
 Modules/_ctypes/_ctypes.c | 98 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++----------------------------
 Modules/_curses_panel.c | 7 +++++--
 Modules/_elementtree.c | 81 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++---------------------
 Modules/_json.c | 7 +++++--
 Modules/_sqlite/connection.c | 28 ++++++++++++++++++++--------
 Modules/_sqlite/cursor.c | 42 ++++++++++++++++++++++++++++++------------
 Modules/bz2module.c | 9 +++++----
 Modules/cPickle.c | 36 +++++++++++++++++++++++++++---------
 Modules/flmodule.c | 28 ++++++++++++++++++++--------
 Modules/itertoolsmodule.c | 7 +++++--
 Modules/selectmodule.c | 7 +++++--
 Modules/signalmodule.c | 7 +++++--
 Modules/svmodule.c | 7 +++++--
 Modules/zlibmodule.c | 23 +++++++++++++++--------
 Objects/descrobject.c | 7 +++++--
 Objects/exceptions.c | 21 +++++++++++++++------
 Objects/fileobject.c | 14 ++++++++++----
 Objects/funcobject.c | 7 +++++--
 Objects/typeobject.c | 21 +++++++++++++++------
 Python/ceval.c | 7 +++++--
 Python/sysmodule.c | 7 +++++--
 25 files changed, 382 insertions(+), 152 deletions(-)
History
Date User Action Args
2012年11月09日 01:14:50vstinnersetrecipients: + vstinner, amaury.forgeotdarc
2012年11月09日 01:14:50vstinnersetmessageid: <1352423690.29.0.110802131091.issue16447@psf.upfronthosting.co.za>
2012年11月09日 01:14:50vstinnerlinkissue16447 messages
2012年11月09日 01:14:49vstinnercreate

AltStyle によって変換されたページ (->オリジナル) /