Message172014
| Author |
pitrou |
| Recipients |
Arfrever, christian.heimes, eli.bendersky, ezio.melotti, flox, georg.brandl, pitrou, python-dev, skrah |
| Date |
2012年10月04日.22:46:58 |
| SpamBayes Score |
-1.0 |
| Marked as misclassified |
Yes |
| Message-id |
<1349390740.3353.3.camel@localhost.localdomain> |
| In-reply-to |
<1349390250.7.0.260012333319.issue16089@psf.upfronthosting.co.za> |
| Content |
> > the coding style there is quite old
>
> It would be great if you could elaborate, however briefly, if there's
> anything else besides your fixes that is old and should be modernized.
> I will admit to writing some of that code very recently, but that's
> mostly because I was trying to follow the existing coding style of the
> module, which was written a long time ago.
I don't think that's you. I was talking about some of the cruft I
removed (such as list_join() which was going through complicated hoops
instead of calling PyUnicode_Join(), or manual filling of tuples instead
of calling PyTuple_Pack()).
There are still issues with internal functions stealing references and
such. |
|