Message170984
| Author |
pitrou |
| Recipients |
Arfrever, ezio.melotti, pitrou, serhiy.storchaka, skrah |
| Date |
2012年09月22日.10:31:09 |
| SpamBayes Score |
-1.0 |
| Marked as misclassified |
Yes |
| Message-id |
<1348309826.3392.1.camel@localhost.localdomain> |
| In-reply-to |
<1348309520.61.0.174939526797.issue15958@psf.upfronthosting.co.za> |
| Content |
> Attached new refleakless patch.
Your approach is dangerous, because the buffers may change size between
two calls to PyObject_GetBuffer(). I think you should keep the
Py_buffers alive in an array, and only release them at the end (it may
also be slightly faster to do so).
A nit: you are adding a lot of newlines in test_bytes.py. |
|