Message170154
| Author |
belopolsky |
| Recipients |
Robin.Schreiber, asvetlov, belopolsky, pitrou |
| Date |
2012年09月10日.02:46:40 |
| SpamBayes Score |
-1.0 |
| Marked as misclassified |
Yes |
| Message-id |
<1347245201.49.0.718958706554.issue15390@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
For some reason there are no review links, so I'll review in this message.
Include/datetime.h
+typedef struct {
..
+} _datetimemodulestate;
Names exposed in public headers (datetime.h is a public header) should start with Py or _Py. Other offenders include _datetimemodule_state, _datetimemodule, _datetimemodulestate_global.
I don't think these names need to be defined in the header file at all.
+typedef struct {
+ /* Forward declarations. */
+ PyObject *PyDateTime_DateType;
+ PyObject *PyDateTime_DateTimeType;
...
These are not forward declarations anymore. There is no need for PyDateTime_ prefix. Use names from PyDateTime_CAPI struct. |
|
History
|
|---|
| Date |
User |
Action |
Args |
| 2012年09月10日 02:46:41 | belopolsky | set | recipients:
+ belopolsky, pitrou, asvetlov, Robin.Schreiber |
| 2012年09月10日 02:46:41 | belopolsky | set | messageid: <1347245201.49.0.718958706554.issue15390@psf.upfronthosting.co.za> |
| 2012年09月10日 02:46:40 | belopolsky | link | issue15390 messages |
| 2012年09月10日 02:46:40 | belopolsky | create |
|