Message170141
| Author |
christian.heimes |
| Recipients |
brett.cannon, christian.heimes |
| Date |
2012年09月09日.22:23:13 |
| SpamBayes Score |
-1.0 |
| Marked as misclassified |
Yes |
| Message-id |
<1347229394.03.0.409721609393.issue15894@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
Coverity claims that the call to PyThread_acquire_lock with NOWAIT_LOCK can fail. It sounds plausible as you don't wait for the lock to succeed.
CID 486861: Unchecked return value (CHECKED_RETURN)At (3): Calling function "PyThread_acquire_lock(PyThread_type_lock, int)" without checking return value (as is done elsewhere 22 out of 23 times).
At (9): No check of the return value of "PyThread_acquire_lock(import_lock, 0)".
205 PyThread_acquire_lock(import_lock, 0);
206 /* XXX: can the previous line fail? */
By the way the code would be more readable with NOWAIT_LOCK instead of 0. |
|
History
|
|---|
| Date |
User |
Action |
Args |
| 2012年09月09日 22:23:14 | christian.heimes | set | recipients:
+ christian.heimes, brett.cannon |
| 2012年09月09日 22:23:14 | christian.heimes | set | messageid: <1347229394.03.0.409721609393.issue15894@psf.upfronthosting.co.za> |
| 2012年09月09日 22:23:13 | christian.heimes | link | issue15894 messages |
| 2012年09月09日 22:23:13 | christian.heimes | create |
|