Message169731
| Author |
belopolsky |
| Recipients |
Robin.Schreiber, belopolsky, loewis |
| Date |
2012年09月02日.23:37:11 |
| SpamBayes Score |
-1.0 |
| Marked as misclassified |
Yes |
| Message-id |
<1346629032.47.0.617042779766.issue15849@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
+#define xx_state_global
+ ((xxstate *)PyModule_GetState(PyState_FindModule(&xxmodule)))
This is unsafe: PyState_FindModule(&xxmodule) can return NULL. I think code should account for this possibility and not use this macro. For example, XxoObject_Check(v) should be defined as
(PyState_FindModule(&xxmodule) == NULL ? 0 : \
(Py_TYPE(v) == xx_state(PyState_FindModule(&xxmodule))->Xxo_Type))
(Should this also check PyModule_GetState() return?) |
|
History
|
|---|
| Date |
User |
Action |
Args |
| 2012年09月02日 23:37:12 | belopolsky | set | recipients:
+ belopolsky, loewis, Robin.Schreiber |
| 2012年09月02日 23:37:12 | belopolsky | set | messageid: <1346629032.47.0.617042779766.issue15849@psf.upfronthosting.co.za> |
| 2012年09月02日 23:37:12 | belopolsky | link | issue15849 messages |
| 2012年09月02日 23:37:11 | belopolsky | create |
|