Message169576
| Author |
skrah |
| Recipients |
Alexander.Belopolsky, belopolsky, docs@python, ncoghlan, pitrou, skrah |
| Date |
2012年08月31日.19:12:11 |
| SpamBayes Score |
-1.0 |
| Marked as misclassified |
Yes |
| Message-id |
<20120831191212.GA2642@sleipnir.bytereef.org> |
| In-reply-to |
<CAP7h-xbddU2uc=UEL=TGTeY3dBJf+kfV1qS=8PYGohikWY5y8A@mail.gmail.com> |
| Content |
Alexander Belopolsky <report@bugs.python.org> wrote:
> I am still getting up to speed with all the changes that went in since
> 3.2. I'll review your patch over the weekend. Meanwhile, I think the
> goal should be that after PyMemoryview_FromBuffer(info) is called, it
> should be OK to discard info by calling PyBuffer_Release()
Now I'm puzzled: I thought your goal was to preserve the implicit cleanup
from 3.2, i.e. PyBuffer_Release() is called when the managed buffer is
deallocated.
Without the patch it's OK to call PyBuffer_Release(info) after
PyMemoryview_FromBuffer(info). With the patch you can't call
PyBuffer_Release(info), since it's done automatically already. |
|