Message169489
| Author |
loewis |
| Recipients |
loewis, ned.deily, petri.lehtinen, python-dev, sbt, trent |
| Date |
2012年08月30日.19:50:49 |
| SpamBayes Score |
-1.0 |
| Marked as misclassified |
Yes |
| Message-id |
<1346356250.25.0.783543861568.issue15819@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
As a further follow-up: the original code (in 67ed8a6905c3, by Neil Schemenauer from 2001), he explicitly changed GRAMMAR_C/H to refer to srcdir, claiming that errors from building them would be ignored.
In r87558, for which I can't find a subversion revsision for, Victor Stinner dropped the Makefile "-" marker, making the read-only case fail.
In reviewing the patch more, I think it is actually incorrect: it now generates the files into Include, but they aren't considered there since (builddir)/Include is not added to the -I options.
So the two options now are:
a) revert the patch, and restore Neil's original approach, or
b) add Include to the -I options, if srcdir is not "."
Reopening for consideration. |
|