Message169047
| Author |
pitrou |
| Recipients |
pitrou, sbt, schmir, vstinner |
| Date |
2012年08月24日.16:49:10 |
| SpamBayes Score |
-1.0 |
| Marked as misclassified |
Yes |
| Message-id |
<1345826749.3368.12.camel@localhost.localdomain> |
| In-reply-to |
<1345826557.52.0.241028642575.issue15758@psf.upfronthosting.co.za> |
| Content |
> For this benchmark the call overhead does not seem to be noticeable,
> and using larger or adaptive read buffers does not seem to help
> either. (I have tried both on Linux.)
Ok, thank you.
> > By the way, not every non-Windows OS is Linux, so the patch is wrong.
>
> Wrong in the sense of not necessarily optimal for unknown platforms?
> Well, the patch retains the old (intended) behaviour on other
> platforms, so I would call that conservative rather than wrong.
Hmm, you are right, there is no regression indeed.
I guess I don't like very much the idea of switching code paths based on
the platform for pure optimization reasons, but in this case it seems
useful (and simple enough).
> Are you suggesting switching behaviour depending on whether some macro
> is defined?
No, that would definitely be overkill. |
|