Message167983
| Author |
chris.jerdonek |
| Recipients |
anton.barkovsky, chris.jerdonek, georg.brandl, r.david.murray |
| Date |
2012年08月11日.17:43:48 |
| SpamBayes Score |
-1.0 |
| Marked as misclassified |
Yes |
| Message-id |
<1344707029.77.0.498607167937.issue15557@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
It seems like these tests can be made more DRY. For example, the line `args = popen.cmd_line` appears in every test. You could make an assert_args() helper method to address this. There also seems to be a lot of overlap between tests for each browser. A DRY approach would let one see more easily how the tests differ across browsers.
Do you also need to include the test boilerplate at the bottom? See, for example--
http://hg.python.org/cpython/file/867de88b69f0/Lib/test/test_textwrap.py#l732 |
|