Message 167072 - Python tracker

➜

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

In-reply-to
Author	chris.jerdonek
Recipients	cbc, chris.jerdonek
Date	2012年08月01日.02:19:52
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1343787594.04.0.851758920078.issue15518@psf.upfronthosting.co.za>

Content
Thanks, Chris. A couple high-level comments. I know this isn't the prevailing style of the existing tests, but it's generally better if each unit test tests just one thing. That way, for example, if a test fails you know more precisely what is not working. Would it be possible to structure things so that you have tests like test_report(), test_report_partial_closure(), etc? Also, is there any reason you need to be using a regular expression as opposed to an exact string match?

Content

Thanks, Chris. A couple high-level comments.
I know this isn't the prevailing style of the existing tests, but it's generally better if each unit test tests just one thing. That way, for example, if a test fails you know more precisely what is not working.
Would it be possible to structure things so that you have tests like test_report(), test_report_partial_closure(), etc?
Also, is there any reason you need to be using a regular expression as opposed to an exact string match?

History
Date	User	Action	Args
2012年08月01日 02:19:54	chris.jerdonek	set	recipients: + chris.jerdonek, cbc
2012年08月01日 02:19:54	chris.jerdonek	set	messageid: <1343787594.04.0.851758920078.issue15518@psf.upfronthosting.co.za>
2012年08月01日 02:19:53	chris.jerdonek	link	issue15518 messages
2012年08月01日 02:19:52	chris.jerdonek	create

homepage