Message166564
| Author |
ncoghlan |
| Recipients |
benjamin.peterson, christian.heimes, georg.brandl, meador.inge, ncoghlan, pitrou, python-dev, skrah, vstinner |
| Date |
2012年07月27日.13:28:16 |
| SpamBayes Score |
-1.0 |
| Marked as misclassified |
Yes |
| Message-id |
<1343395697.27.0.137952852379.issue12834@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
Summary of my review for Georg's benefit: I had one minor formatting nit with the patch (which Stefan can easily fix before committing), but it otherwise looked fine to me.
I also agree that the old implicit truncation was unusable in practice, as the *actual* length is not returned from the function, and in fact cannot be returned because the return type is int rather than Py_ssize_t. A length mismatch therefore needs to be an error. |
|