Message 166560 - Python tracker

➜

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

In-reply-to
Author	amaury.forgeotdarc
Recipients	amaury.forgeotdarc, brian.curtin, jkloth, kristjan.jonsson, sbt
Date	2012年07月27日.12:51:36
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1343393497.25.0.350214951328.issue15431@psf.upfronthosting.co.za>

Content
IMO dependencies is not a big issue here. In the worst case, the developer can build a second time... I think your patch won't work on Unix machines: _freeze_importlib.c is linked with all Python files except frozen.c which defines PyImport_FrozenModules. #ifdef should be used IMO. Also, I noticed that the marshalled code is different. The first difference a 32bit vs. 64bit issue: 0xFFFFFFFF is marshalled as a TYPE_INT64 on 64bit platforms, but as a TYPE_LONG on 32bit platforms. See issue15466.

Content

IMO dependencies is not a big issue here. In the worst case, the developer can build a second time...
I think your patch won't work on Unix machines: _freeze_importlib.c is linked with all Python files *except* frozen.c which defines PyImport_FrozenModules. #ifdef should be used IMO.
Also, I noticed that the marshalled code is different. The first difference a 32bit vs. 64bit issue: 0xFFFFFFFF is marshalled as a TYPE_INT64 on 64bit platforms, but as a TYPE_LONG on 32bit platforms. See issue15466.

History
Date	User	Action	Args
2012年07月27日 12:51:37	amaury.forgeotdarc	set	recipients: + amaury.forgeotdarc, kristjan.jonsson, jkloth, brian.curtin, sbt
2012年07月27日 12:51:37	amaury.forgeotdarc	set	messageid: <1343393497.25.0.350214951328.issue15431@psf.upfronthosting.co.za>
2012年07月27日 12:51:36	amaury.forgeotdarc	link	issue15431 messages
2012年07月27日 12:51:36	amaury.forgeotdarc	create

homepage