Message 166297 - Python tracker

➜

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

In-reply-to
Author	anton.barkovsky
Recipients	anton.barkovsky, eric.araujo, gregory.p.smith, orsenthil
Date	2012年07月24日.14:22:01
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1343139722.48.0.669514028104.issue11466@psf.upfronthosting.co.za>

Content
I think I've found the root cause. On my system (also tested in 3.2) /dev/tty is opened successfully, but wrapping it in io.BufferedRandom fails. By the time the exception is raised, FileIO object is already created, and then it immediately gets deleted. I'm attaching a patch that closes the file explicitly in this case. Be extra careful when reviewing though - this is the first time I'm touching Python's C code.

Content

I think I've found the root cause.
On my system (also tested in 3.2) /dev/tty is opened successfully, but wrapping it in io.BufferedRandom fails. By the time the exception is raised, FileIO object is already created, and then it immediately gets deleted.
I'm attaching a patch that closes the file explicitly in this case.
Be extra careful when reviewing though - this is the first time I'm touching Python's C code.

History
Date	User	Action	Args
2012年07月24日 14:22:02	anton.barkovsky	set	recipients: + anton.barkovsky, gregory.p.smith, orsenthil, eric.araujo
2012年07月24日 14:22:02	anton.barkovsky	set	messageid: <1343139722.48.0.669514028104.issue11466@psf.upfronthosting.co.za>
2012年07月24日 14:22:01	anton.barkovsky	link	issue11466 messages
2012年07月24日 14:22:01	anton.barkovsky	create

homepage