Message166257
| Author |
meador.inge |
| Recipients |
asvetlov, gregory.p.smith, jcea, loewis, mark.dickinson, meador.inge, python-dev, serhiy.storchaka |
| Date |
2012年07月24日.01:05:19 |
| SpamBayes Score |
-1.0 |
| Marked as misclassified |
Yes |
| Message-id |
<1343091921.38.0.635974086873.issue15402@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
On Mon, Jul 23, 2012 at 5:04 PM, Martin v. Löwis <report@bugs.python.org> wrote:
> The patch that Meador committed is incorrect: METH_NOARGS functions
> still take a PyObject* args argument, which will be NULL. I'm puzzled, as
> Serhiy's original patch was correct.
I almost committed the two-argument version with the 'unused' parameter, but
then I had the bright idea to look at how '__sizeof__' is implemented elsewhere
in the interpreter:
static PyObject *
list_sizeof(PyListObject *self);
static PyObject *
dict_sizeof(PyDictObject *mp);
static PyObject *
set_sizeof(PySetObject *so);
etc ...
So I dropped the 'unused' parmeter for the 'struct' implementation:
static PyObject *
s_sizeof(PyStructObject *self);
I will happily fix it, but if it is wrong one place, then it is wrong
everywhere. |
|