Message165930
| Author |
hltbra |
| Recipients |
alex, dwt, eric.snow, ezio.melotti, hltbra, mrabarnett, pitrou, rhettinger, terry.reedy |
| Date |
2012年07月20日.14:29:30 |
| SpamBayes Score |
-1.0 |
| Marked as misclassified |
Yes |
| Message-id |
<1342794573.02.0.344858852798.issue13592@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
Thanks for the review ezio.melotti.
He has notice a few things in my patch:
* assertEquals is deprecated; should use assertEqual
* the convention is assertEqual(result, expected), not assertEqual(expected, result)
* it should handle quotes correctly
* some lines were longer than 80 chars
* add tests using inline flags (re.I instead of re.IGNORECASE)
And I realized I was not covering the case where no flags are enabled (byte string, for instance). And I have fixed all this issues.
And now I think this patch would work against py2x and py3k anyway.
Attaching a new patch. |
|