Message 165277 - Python tracker

➜

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

In-reply-to
Author	roger.serwy
Recipients	loewis, roger.serwy, serhiy.storchaka, terry.reedy
Date	2012年07月12日.00:33:23
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1342053206.78.0.533392752216.issue15318@psf.upfronthosting.co.za>

Content
I tested blockfile-3.diff against the latest code in the repository. sys.stdin.write returns the wrong error message when passed a non-string. Presently it returns io.UnsupportedOperation instead of TypeError: must be str, not ... The attached blockfile-4.diff incorporates blockfile-3 and creates a decorator in _RPCFile to ensure the argument is a string and applies it to the _RPCInputFile and _RPCOutputFile write methods. A simpler alternative would be duplicating the string check code in _RPCInputFile before the raise statement.

Content

I tested blockfile-3.diff against the latest code in the repository.
sys.stdin.write returns the wrong error message when passed a non-string. Presently it returns io.UnsupportedOperation instead of TypeError: must be str, not ...
The attached blockfile-4.diff incorporates blockfile-3 and creates a decorator in _RPCFile to ensure the argument is a string and applies it to the _RPCInputFile and _RPCOutputFile write methods.
A simpler alternative would be duplicating the string check code in _RPCInputFile before the raise statement.

History
Date	User	Action	Args
2012年07月12日 00:33:27	roger.serwy	set	recipients: + roger.serwy, loewis, terry.reedy, serhiy.storchaka
2012年07月12日 00:33:26	roger.serwy	set	messageid: <1342053206.78.0.533392752216.issue15318@psf.upfronthosting.co.za>
2012年07月12日 00:33:26	roger.serwy	link	issue15318 messages
2012年07月12日 00:33:25	roger.serwy	create

homepage