Message 164608 - Python tracker

➜

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

In-reply-to
Author	apalala
Recipients	apalala, cblp, vinay.sajip
Date	2012年07月03日.15:31:02
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1341329464.27.0.922555841967.issue14902@psf.upfronthosting.co.za>

Content
I did extensive testing on time.timezone, and it is correct as far as the current date is concerned. The problem, as mentioned before, is that test_logging is using time.timezone for dates in the past for which the time zone may have been different from the current one on the current location. The attached patch shows that time calculations involving time.timezone may not be valid for dates different from the current one, as not even daylight-savings/summer times are taken into account, so the test may also fail depending on the time of the year it is run on.

Content

I did extensive testing on time.timezone, and it is correct as far as the current date is concerned. The problem, as mentioned before, is that test_logging is using time.timezone for dates in the past for which the time zone may have been different from the current one on the current location.
The attached patch shows that time calculations involving time.timezone may not be valid for dates different from the current one, as not even daylight-savings/summer times are taken into account, so the test may also fail depending on the time of the year it is run on.

History
Date	User	Action	Args
2012年07月03日 15:31:04	apalala	set	recipients: + apalala, vinay.sajip, cblp
2012年07月03日 15:31:04	apalala	set	messageid: <1341329464.27.0.922555841967.issue14902@psf.upfronthosting.co.za>
2012年07月03日 15:31:03	apalala	link	issue14902 messages
2012年07月03日 15:31:03	apalala	create

homepage