Message 163970 - Python tracker

➜

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

In-reply-to
Author	r.david.murray
Recipients	bkabrda, r.david.murray
Date	2012年06月25日.14:01:04
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1340632864.99.0.786784341337.issue15178@psf.upfronthosting.co.za>

Content
Great, thanks. There's a loop around testfiles. I think it would be nicer to not call sys.exit. You could at the same time fix what appears to be a bug in the loop code. It looks like 1 is currently returned only if the last file fails. Hmm, and given that there is a bug, adding tests would be great if you are up for it. I don't think there are currently any tests of the doctest command line functionality. That's more complicated than writing the fix, though :)

Content

Great, thanks.
There's a loop around testfiles. I think it would be nicer to not call sys.exit. You could at the same time fix what appears to be a bug in the loop code. It looks like 1 is currently returned only if the last file fails.
Hmm, and given that there is a bug, adding tests would be great if you are up for it. I don't think there are currently any tests of the doctest command line functionality. That's more complicated than writing the fix, though :)

History
Date	User	Action	Args
2012年06月25日 14:01:05	r.david.murray	set	recipients: + r.david.murray, bkabrda
2012年06月25日 14:01:04	r.david.murray	set	messageid: <1340632864.99.0.786784341337.issue15178@psf.upfronthosting.co.za>
2012年06月25日 14:01:04	r.david.murray	link	issue15178 messages
2012年06月25日 14:01:04	r.david.murray	create

homepage