Message163009
| Author |
meador.inge |
| Recipients |
Arfrever, benjamin.peterson, brett.cannon, eric.smith, eric.snow, loewis, meador.inge, ncoghlan, pitrou |
| Date |
2012年06月17日.03:50:09 |
| SpamBayes Score |
-1.0 |
| Marked as misclassified |
Yes |
| Message-id |
<1339905010.54.0.729949451828.issue14928@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
Nice patch Antoine! The method of partitioning the object sets into frozen and
non-frozen is nice.
> The proposed "-X" or BOOTSTRAP_PY approaches would be difficult, since there
> doesn't appear to be an easy way to generate a given file (the Python
> interpreter) twice in a Makefile dependency chain: the first time using the
> stale importlib, the second with the fresh importlib.
I experimented with the env var approach and came to the exact same conclusion
-- you would have to build the interpreter twice.
This patch looks good to me (I did have to rebase it against trunk, though;
it doesn't apply cleanly right now). I did some basic regression testing and ran
it through the original scenario from issue12370 that got us thinking this problem.
I saw no issues. Nice work. |
|