Message 162666 - Python tracker

➜

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

In-reply-to
Author	ncoghlan
Recipients	eric.araujo, kisielk, ncoghlan
Date	2012年06月12日.11:53:55
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1339502037.89.0.341645362161.issue15033@psf.upfronthosting.co.za>

Content
Technically, it returns -1 (which later gets coerced to an unsigned value). However, there's no good reason for the inconsistency - the offending line (663) in main.c should be changed to be: sts = (RunModule(module, 1) != 0); It is currently just: sts = RunModule(module, 1); An additional test in test_cmd_line_script is also needed to ensure that both variants give a returncode of 1 in the future.

Content

Technically, it returns -1 (which later gets coerced to an unsigned value).
However, there's no good reason for the inconsistency - the offending line (663) in main.c should be changed to be:
 sts = (RunModule(module, 1) != 0);
It is currently just:
 sts = RunModule(module, 1);
An additional test in test_cmd_line_script is also needed to ensure that both variants give a returncode of 1 in the future.

History
Date	User	Action	Args
2012年06月12日 11:54:00	ncoghlan	set	recipients: + ncoghlan, kisielk, eric.araujo
2012年06月12日 11:53:57	ncoghlan	set	messageid: <1339502037.89.0.341645362161.issue15033@psf.upfronthosting.co.za>
2012年06月12日 11:53:56	ncoghlan	link	issue15033 messages
2012年06月12日 11:53:55	ncoghlan	create

homepage