Message 162382 - Python tracker

➜

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

In-reply-to
Author	larry
Recipients	benjamin.peterson, larry
Date	2012年06月06日.00:03:43
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1338941027.91.0.431928620317.issue14769@psf.upfronthosting.co.za>

Content
I guess the answer was "no". Attached is a new diff as you suggest. It isn't really any shorter--in fact it's about 20% longer. Though I freely admit it is more written-in-Python-y. The test currently passes. If you add support for a new format unit (like add "case '8':" above "case 'H':" in convertsimple()) without adding the corresponding case to simpleitem(), it fails. If you perform the same operation on simpleitem() but not to convertsimple(), it again fails. So I assert the test is working 100% correctly.

Content

I guess the answer was "no".
Attached is a new diff as you suggest. It isn't really any shorter--in fact it's about 20% longer. Though I freely admit it is more written-in-Python-y.
The test currently passes. If you add support for a new format unit (like add "case '8':" above "case 'H':" in convertsimple()) without adding the corresponding case to simpleitem(), it fails. If you perform the same operation on simpleitem() but not to convertsimple(), it again fails. So I assert the test is working 100% correctly.

History
Date	User	Action	Args
2012年06月06日 00:03:48	larry	set	recipients: + larry, benjamin.peterson
2012年06月06日 00:03:47	larry	set	messageid: <1338941027.91.0.431928620317.issue14769@psf.upfronthosting.co.za>
2012年06月06日 00:03:47	larry	link	issue14769 messages
2012年06月06日 00:03:46	larry	create

homepage