Message 160400 - Python tracker

➜

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

In-reply-to
Author	pitrou
Recipients	dmalcolm, eric.araujo, jcea, loewis, pitrou
Date	2012年05月11日.04:53:30
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1336712011.69.0.21304580621.issue14776@psf.upfronthosting.co.za>

Content
Well, at least it looks much cleaner that the dtrace patch. Two comments still: - is pysystemtap.h meant to be a public header? otherwise it should perhaps not end up in Include (I'm not sure what our policy is here) - perhaps get_frame_marker_info() and friends could still be a in separate ceval-systemtap.h file? that way the only added complication in ceval.c would be a couple of includes, and the two `if`s in the eval loop

Content

Well, at least it looks much cleaner that the dtrace patch.
Two comments still:
- is pysystemtap.h meant to be a public header? otherwise it should perhaps not end up in Include (I'm not sure what our policy is here)
- perhaps get_frame_marker_info() and friends could still be a in separate ceval-systemtap.h file? that way the only added complication in ceval.c would be a couple of includes, and the two `if`s in the eval loop

History
Date	User	Action	Args
2012年05月11日 04:53:31	pitrou	set	recipients: + pitrou, loewis, jcea, eric.araujo, dmalcolm
2012年05月11日 04:53:31	pitrou	set	messageid: <1336712011.69.0.21304580621.issue14776@psf.upfronthosting.co.za>
2012年05月11日 04:53:31	pitrou	link	issue14776 messages
2012年05月11日 04:53:30	pitrou	create

homepage