Message160115
| Author |
serhiy.storchaka |
| Recipients |
nadeem.vawda, pitrou, serhiy.storchaka |
| Date |
2012年05月06日.23:05:27 |
| SpamBayes Score |
-1.0 |
| Marked as misclassified |
Yes |
| Message-id |
<1336345528.41.0.868231189346.issue14736@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
Thank you, Nadeem Vawda. I also wrote a patch for this, but because of the lack of experience it was too cumbersome.
But there are no tests for these functions. I tried to use these functions and got the random values.
>>> lzma.decode_filter_properties(lzma.FILTER_LZMA1, lzma.encode_filter_properties({'id': lzma.FILTER_LZMA1, 'preset': 6}))
{'mode': 3075124424, 'dict_size': 8388608, 'id': 4611686018427387905, 'lp': 0, 'nice_len': 739426833, 'depth': 0, 'lc': 3, 'mf': 0, 'pb': 2}
>>> lzma.decode_filter_properties(lzma.FILTER_LZMA1, lzma.encode_filter_properties({'id': lzma.FILTER_LZMA1, 'preset': 6}))
{'mode': 0, 'dict_size': 8388608, 'id': 4611686018427387905, 'lp': 0, 'nice_len': 2053908595, 'depth': 0, 'lc': 3, 'mf': 0, 'pb': 2}
>>> lzma.decode_filter_properties(lzma.FILTER_LZMA1, lzma.encode_filter_properties({'id': lzma.FILTER_LZMA1, 'preset': 6}))
{'mode': 0, 'dict_size': 8388608, 'id': 4611686018427387905, 'lp': 0, 'nice_len': 2053908595, 'depth': 0, 'lc': 3, 'mf': 0, 'pb': 2}
It seems, 'mode' and 'nice_len' was not initialized.
Tests for zipfile module with the use of these functions are broken, and I don't know, this happens because of errors in these functions or in zipfile module. |
|
History
|
|---|
| Date |
User |
Action |
Args |
| 2012年05月06日 23:05:28 | serhiy.storchaka | set | recipients:
+ serhiy.storchaka, pitrou, nadeem.vawda |
| 2012年05月06日 23:05:28 | serhiy.storchaka | set | messageid: <1336345528.41.0.868231189346.issue14736@psf.upfronthosting.co.za> |
| 2012年05月06日 23:05:27 | serhiy.storchaka | link | issue14736 messages |
| 2012年05月06日 23:05:27 | serhiy.storchaka | create |
|