Message160092
| Author |
pitrou |
| Recipients |
Arfrever, brett.cannon, eric.snow, nadeem.vawda, pitrou, skrah |
| Date |
2012年05月06日.16:31:59 |
| SpamBayes Score |
-1.0 |
| Marked as misclassified |
Yes |
| Message-id |
<1336321804.3336.6.camel@localhost.localdomain> |
| In-reply-to |
<1336321440.61.0.280194133984.issue14583@psf.upfronthosting.co.za> |
| Content |
> One, you have some "XXX False" markers in the tests. Should those get
> deleted or replaced with something?
Well, I don't know what to replace them with. I would have expected
pkg.module to end up in sys.modules, but as mentioned in the comments
the relative import line actually fails with an ImportError. There's
probably some logic behind that, but that's beyond me.
> Two, in your first test (at least) you only test what is in
> sys.modules once instead of after each attempted import. I would
> repeat the test after each import.
Ok, will do. |
|