Message 159949 - Python tracker

➜

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

In-reply-to
Author	pitrou
Recipients	brian.curtin, kristjan.jonsson, loewis, pitrou, python-dev, sbt, tim.golden
Date	2012年05月04日.17:34:36
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1336152877.43.0.0458180409788.issue11618@psf.upfronthosting.co.za>

Content
I agree that Martin that it's not a good idea to add "dead" code. Furthermore, you patch has: +#ifndef _PY_EMULATED_WIN_CV +#define _PY_EMULATED_WIN_CV 0 /* use emulated condition variables */ +#endif + +#if !defined NTDDI_VISTA \|\| NTDDI_VERSION < NTDDI_VISTA +#undef _PY_EMULATED_WIN_CV +#define _PY_EMULATED_WIN_CV 1 +#endif so am I right to understand that when compiled under Vista or later, it will produce an XP-incompatible binary?

Content

I agree that Martin that it's not a good idea to add "dead" code.
Furthermore, you patch has:
+#ifndef _PY_EMULATED_WIN_CV
+#define _PY_EMULATED_WIN_CV 0 /* use emulated condition variables */
+#endif
+
+#if !defined NTDDI_VISTA || NTDDI_VERSION < NTDDI_VISTA
+#undef _PY_EMULATED_WIN_CV
+#define _PY_EMULATED_WIN_CV 1
+#endif
so am I right to understand that when compiled under Vista or later, it will produce an XP-incompatible binary?

History
Date	User	Action	Args
2012年05月04日 17:34:37	pitrou	set	recipients: + pitrou, loewis, kristjan.jonsson, tim.golden, brian.curtin, python-dev, sbt
2012年05月04日 17:34:37	pitrou	set	messageid: <1336152877.43.0.0458180409788.issue11618@psf.upfronthosting.co.za>
2012年05月04日 17:34:36	pitrou	link	issue11618 messages
2012年05月04日 17:34:36	pitrou	create

homepage