Message159670
| Author |
neologix |
| Recipients |
giampaolo.rodola, gregory.p.smith, loewis, neologix, pitrou, qyb |
| Date |
2012年04月30日.07:44:30 |
| SpamBayes Score |
-1.0 |
| Marked as misclassified |
Yes |
| Message-id |
<1335771871.67.0.628879152688.issue1522400@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
> Actually I think it suffers from the same problem as AF_UNIX:
> sockaddr_irda->sir_name, like sockaddr_un->sun_path, don't have to be
> NUL-terminated, and the kernel can return non NUL-terminated strings.
Actually, I've had a look at the Linux and Windows documentation, and sir_name is NUL-terminated. I've also had a look at the kernel source, and it treats sir_name as NUL-terminated, so it should be safe.
Here's a new patch, with a couple new constants, documentation update and some - really basic - tests.
I guess Gregory is right, and we could push this as-is, and wait until some users is interested in improving the support and tests. |
|